Addictions 2 electric boogaloo #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: YML
|
rest in piss doping burgers with addictine |
|
Long story short for everyone who didn't understand "fixes the stupid addictions forever". Addictions will no longer use the system they did before, wherein they would add a reagent (addictine) to your bloodstream which would make you act up and tweak a bunch even in minor quantities (you eat one dank pizza slice and suddenly you crave weed all day every day). Now it's more similar to alcohol and hallucinogens of old, where it applies a status effect. It makes more sense now. Obv. dir. approv |
deltanedas
requested changes
Sep 24, 2024
deltanedas
requested changes
Sep 24, 2024
i stashed it and never committed it after merging master :blunt: |
|
@deltanedas it's been 2 weeks re-review pretty please |
deltanedas
requested changes
Nov 3, 2024
deltanedas
added
Status: Awaiting Changes
|
ok I'll be real i had no idea what I was doing back then |
deltanedas
requested changes
Nov 3, 2024
MilonPL
force-pushed
the
addictions-2-electric-boogaloo
branch
from
681a83e
to
5bbdb9c
Compare
github-actions
bot
added
Status: Needs Review
and removed
Status: Awaiting Changes
Signed-off-by: deltanedas <[email protected]>
deltanedas
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
fixes the stupid addictions (forever??)
doesn't actually modify reagents yet, I'll just PR this to CD and pull the changes from there instead of commenting everything
Why / Balance
outdated and not really balanced for MRP
fun fact: I originally learned C# just to fix this one thing
Technical details
uses StatusEffects, the code should be pretty well documented
the SharedAddictionSystem is responsible for adding the status effects, AddictionSystem does all of the updates on the component, the component stores the TimeSpan of last addictive substance metabolism cycle, i spent 3 days figuring out how to solve the issue of suppressing pop-ups
Requirements
Breaking changes
Changelog
no fun yet since it's just the system